feat: support extracting a module config from the local environment #1331
Conversation
This is intended primarily for local development/testing. Currently now this will load from ftl-project.toml and environment variables, but at some point the envars will be removed.
alecthomas
force-pushed
the
aat/module-context-from-environment
branch
from
e2a8063 to
1d083b8
Compare
| @@ -84,6 +85,9 @@ func loadFile(path string) (Config, error) { | |||
| config := Config{} | |||
| md, err := toml.DecodeFile(path, &config) | |||
| if err != nil { | |||
| if errors.Is(err, os.ErrNotExist) { | |||
There was a problem hiding this comment.
This allows ftl config to operate when the ftl-project.toml file doesn't exist yet.
| ) | ||
|
|
||
| // Module returns the FTL module currently being executed. | ||
| func Module() string { |
There was a problem hiding this comment.
👏 I was wanting this more generaly and didnt want to call config.go's callerModule()
And it seems that pfi wanted it in some cases as well: https://github.com/tbdeng/pfi/blob/ef7ee116ca4dc269dc9cc857187e2b0f5e697489/backend/modules/tbdex/offerings/offerings.go#L17
| @@ -647,14 +648,18 @@ func (s *Service) GetModuleContext(ctx context.Context, req *connect.Request[ftl | |||
| if err != nil { | |||
| return nil, connect.NewError(connect.CodeInternal, fmt.Errorf("could not get active schemas: %w", err)) | |||
| } | |||
| schema, ok := slices.Find(schemas, func(s *schema.Module) bool { return s.Name == req.Msg.Module }) | |||
| module, ok := slices.Find(schemas, func(s *schema.Module) bool { return s.Name == req.Msg.Module }) | |||
There was a problem hiding this comment.
Looks like configs, secrets and DSNs are now discovered without needing the declarations from a module. So the db query to find module can be skipped
There was a problem hiding this comment.
Now this module var is only used to get the module name, which can just get directly from the req
There was a problem hiding this comment.
Ah another thing on my mind: when should a deployment fail if a config/secret/DSN is missing. I think that was the other reason i was getting the module, so that we could fail earlier.
There was a problem hiding this comment.
Yeah it should fail at startup.
This is intended primarily for local development/testing. Currently now this will load from ftl-project.toml and environment variables, but at some point the envars will be removed.
This also moves all ModuleContext related code into go-runtime/modulecontext.