Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract database into schema for go #1320

Merged
merged 4 commits into from
Apr 23, 2024
Merged

feat: extract database into schema for go #1320

merged 4 commits into from
Apr 23, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Apr 23, 2024

fixes integration tests on main.
modulecontext was not passing along DSNs to modules because the schema never included the database declaration in the schema.

@matt2e matt2e requested a review from a team as a code owner April 23, 2024 06:49
@matt2e matt2e requested review from worstell and removed request for a team April 23, 2024 06:49
@alecthomas alecthomas mentioned this pull request Apr 23, 2024
Open
alecthomas
alecthomas approved these changes Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

go-runtime/compile/schema.go Show resolved Hide resolved
alecthomas
alecthomas reviewed Apr 23, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you manually run the integration tests to check?

@matt2e
Copy link
Collaborator Author

matt2e commented Apr 23, 2024

Yes, this fixes the integration tests 👍

@matt2e matt2e merged commit 5c53193 into main Apr 23, 2024
11 checks passed
@matt2e matt2e deleted the matt2e/integration-test-fix branch April 23, 2024 07:12
@worstell
Copy link
Contributor

awesome thanks for doing this!

@worstell worstell added the approved Marks an already closed PR as approved label Apr 23, 2024
@worstell worstell mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@worstell worstell Awaiting requested review from worstell worstell was automatically assigned from TBD54566975/ftl-team

Assignees
No one assigned
Labels
approved Marks an already closed PR as approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt2e @worstell @alecthomas