feat: chain schema errors in Go for the LSP #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
worstell
force-pushed
the
worstell/20240415-chain-go-errors
branch
2 times, most recently
from
2c6301b to
089fb1d
Compare
percolates errors up the chain of affected exports, e.g. if a type contains schema errors and is used in a verb schema, the errors will be highlighted in the type itself and the failing type will be highlighted in the verb that uses it
worstell
force-pushed
the
worstell/20240415-chain-go-errors
branch
from
089fb1d to
4c09d6d
Compare
wesbillman
approved these changes
Apr 15, 2024
Comment on lines
+277
to
+287
| filename+":58:36-39: invalid request type \"ftl/failing.Request\"\n"+ | ||
| filename+":62:1-1: invalid type \"ftl/failing.Request\"\n"+ | ||
| filename+":62:35-38: invalid request type \"ftl/failing.Request\"\n"+ | ||
| filename+":62:48-48: must return an error but is ftl/failing.Response\n"+ | ||
| filename+":67:1-1: invalid type \"ftl/failing.Request\"\n"+ | ||
| filename+":67:41-44: invalid request type \"ftl/failing.Request\"\n"+ | ||
| filename+":67:55-55: first result must be a struct but is string\n"+ | ||
| filename+":67:63-63: must return an error but is string\n"+ | ||
| filename+":67:63-63: second result must not be ftl.Unit\n"+ | ||
| filename+":74:1-1: verb \"WrongResponse\" already exported\n"+ | ||
| filename+":79:6-6: invalid type \"ftl/failing.BadStruct\"\n"+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
percolates errors up the chain of affected exports, e.g. if a type contains schema errors and is used in a verb schema, the errors will be highlighted in the type itself and the failing type will be highlighted in the verb that uses it