feat: produce errors.pb during go schema extraction #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
worstell
requested review from
alecthomas,
dhanji,
wesbillman and
matt2e
as code owners
Open
worstell
force-pushed
the
worstell/20240410-errorspb-go
branch
from
2a3bbdc to
0204352
Compare
alecthomas
approved these changes
Apr 10, 2024
backend/schema/errors.go
Outdated
| Err error `protobuf:"-"` // Wrapped error, if any | ||
| } | ||
|
|
||
| func (e *Error) ToProto() *schemapb.Error { |
There was a problem hiding this comment.
Is this a Node? Possibly not? If it is though, this should return a proto.Message to comply with that interface.
There was a problem hiding this comment.
It's not, I went back and forth but since it's not actually an element of the schema it felt a little conceptually weird to make it a node. i don't feel strongly though
backend/schema/errors.go
Outdated
| @@ -43,7 +65,7 @@ func ErrorListFromProto(e *schemapb.ErrorList) *ErrorList { | |||
| } | |||
|
|
|||
| func (e Error) Error() string { return fmt.Sprintf("%s-%d: %s", e.Pos, e.EndColumn, e.Msg) } | |||
| func (e Error) Unwrap() error { return e.Err } | |||
| func (e Error) Unwrap() error { return nil } | |||
There was a problem hiding this comment.
If this is unused, just remove it completely - it's an optional interface.
go-runtime/compile/build.go
Outdated
| return fmt.Errorf("failed to write errors: %w", err) | ||
| } | ||
|
|
||
| return fmt.Errorf("failed to extract module schema: %w", errors.Join(otherErrs...)) |
There was a problem hiding this comment.
If otherErrs is empty this will return a weird error, but also doesn't this conflict with the logic above where we only load the errors.pb if this function returns an error? Maybe we want to return the original err here instead?
This approach enables arbitrary runtimes to surface schema errors via proto. Go will use this approach for consistency across runtimes. fixes #1207
worstell
force-pushed
the
worstell/20240410-errorspb-go
branch
from
0204352 to
0a64c47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach enables arbitrary runtimes to surface schema errors via proto. Go will use this approach for consistency across runtimes.
fixes #1207