fix: external_module.go with sinks/sources build failures #1132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
Looks like this is not an issue in Kotlin |
matt2e
requested review from
alecthomas,
dhanji,
wesbillman and
worstell
as code owners
alecthomas
reviewed
Mar 25, 2024
backend/schema/visit.go
Outdated
| return innerVisitExcludingMetadataChildren(n, []Node{}, visit) | ||
| } | ||
|
|
||
| func innerVisitExcludingMetadataChildren(n Node, parents []Node, visit func(n Node, parents []Node, next func() error) error) error { |
There was a problem hiding this comment.
I think it would be simpler to type switch on Verb, manually call Visit() on the Verb's children iff they're not Unit and don't call next() in that case.
There was a problem hiding this comment.
Isn't that an odd separation of concerns though? As in the needs of a specific go scaffolding use case compared to schema/visit.go providing ways to traverse the graph.
Currently this is also called when scaffolding Kotlin (which to be fair, might not be affected by a change like that, not 100% sure).
There was a problem hiding this comment.
Ah I see what you're saying, but no - this is supposed to be universal. It should be true in Kotlin too.
alecthomas
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1095
Sink & Source verbs would have a schema like
but the scaffolded
external_module.goversion of it would be:When generating imports, we were finding
schema.Unitin the verb which triggered an inclusion of ftlThis caused the exernal module to fail to build because ftl was not being used by the generated code.
This fix now skips any unit in the schema if the parent is a verb