refactor: DeploymentName to DeploymentKey #1073
Conversation
matt2e
force-pushed
the
matt2e/deploymentname-as-struct
branch
from
de5cf77 to
062985c
Compare
github-actions
bot
changed the title
backend/controller/dal/dal.go
Outdated
| if name, ok := row.DeploymentName.Get(); ok { | ||
| deployment = optional.Some(model.DeploymentName(name)) | ||
| var zero model.DeploymentName | ||
| if row.DeploymentName != zero { |
There was a problem hiding this comment.
From what I can tell, sqlc won't give us an optional on RunnerRow.DeploymentName because of the coalesce part of the sql statement?
This is also why parsing DeploymentName from "" is returning a DeploymentName without an error, but just a empty deployment name.
Is this all fine in Go or should we be more strict around using optionals vs zero?
There was a problem hiding this comment.
Wasn't this working before? Why would it change now?
There was a problem hiding this comment.
Fixed, optionals are maintained like before. And now parsing a deployment name of "" is an error
backend/controller/dal/dal.go
Outdated
| if name, ok := row.DeploymentName.Get(); ok { | ||
| deployment = optional.Some(model.DeploymentName(name)) | ||
| var zero model.DeploymentName | ||
| if row.DeploymentName != zero { |
There was a problem hiding this comment.
Wasn't this working before? Why would it change now?
internal/model/deployment_name.go
Outdated
| @@ -77,6 +81,6 @@ func (d *DeploymentName) Scan(value any) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func (d *DeploymentName) Value() (driver.Value, error) { | |||
| func (d DeploymentName) Value() (driver.Value, error) { | |||
There was a problem hiding this comment.
sneaking little pointer! :)
matt2e
force-pushed
the
matt2e/deploymentname-as-struct
branch
3 times, most recently
from
e9185cf to
ab70af2
Compare
Separate PR on top of other PR, to separate them out for review This refactors everything to refer to a deployment's key instead of its name, including: - db - events - console
matt2e
force-pushed
the
matt2e/deploymentname-as-struct
branch
from
ab70af2 to
9fcf325
Compare
matt2e
changed the title
This refactors everything to refer to a deployment's key instead of its
name, including: