chore: add test for buildengine deploy #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
approved these changes
Mar 8, 2024
buildengine/deploy.go
Outdated
| // Deploy a module to the FTL controller with the given number of replicas. Optionally wait for the deployment to become ready. | ||
| func Deploy(ctx context.Context, module Module, replicas int32, waitForDeployOnline bool, client ftlv1connect.ControllerServiceClient) error { | ||
| func Deploy(ctx context.Context, module Module, replicas int32, waitForDeployOnline bool, client deployClient) error { |
There was a problem hiding this comment.
This shouldn't be a private type if it's used publicly.
wesbillman
force-pushed
the
add-deploy-test
branch
from
f93e7ab to
05f511e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.