feat: ftl dev now using buildengine #1028
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
alecthomas
reviewed
Mar 6, 2024
buildengine/engine.go
Outdated
| return e.buildWithCallback(ctx, func(ctx context.Context, module Module) error { | ||
| return Deploy(ctx, module, replicas, waitForDeployOnline, e.client) | ||
| }, modules...) | ||
| } | ||
|
|
||
| // Dev builds all specified modules and watches for changes in the engine.Dirs, redeploying as necessary. | ||
| func (e *Engine) Dev(ctx context.Context, period time.Duration, modules ...string) error { |
There was a problem hiding this comment.
I think it was a mistake having Add(), instead I think we should just pass the directories to watch, into the constructor. That will eliminate the need for Add() entirely, and the modules here, and simplify things quite a bit.
| modules.RemoveModule(dir) | ||
| } | ||
| } | ||
| return nil |
There was a problem hiding this comment.
It's all that sweet sweet buildengine magic now :)
wesbillman
force-pushed
the
ftl-dev-buildengine
branch
from
53b8bc6 to
dd9fa51
Compare
wesbillman
force-pushed
the
ftl-dev-buildengine
branch
from
dd9fa51 to
c2ce044
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still a bit more to do here + some testing, but wanted to push up progress.