Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevent schema dependency cycles (#894) #1015

Merged
merged 4 commits into from
Mar 5, 2024
Merged

fix: prevent schema dependency cycles (#894) #1015

merged 4 commits into from
Mar 5, 2024

Conversation

matt2e
Copy link
Collaborator

@matt2e matt2e commented Mar 5, 2024

No description provided.

alecthomas
alecthomas approved these changes Mar 5, 2024
View reviewed changes
Copy link
Collaborator

@alecthomas alecthomas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor comments, but otherwise LGTM!

backend/schema/schema_test.go Outdated Show resolved Hide resolved
backend/schema/validate.go Outdated Show resolved Hide resolved
@matt2e matt2e merged commit a432d45 into main Mar 5, 2024
11 checks passed
@matt2e matt2e deleted the matt2e/validate-dependency-cycles branch March 5, 2024 02:35
@alecthomas alecthomas mentioned this pull request Mar 5, 2024
Open
@wesbillman wesbillman mentioned this pull request Mar 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alecthomas alecthomas alecthomas approved these changes

@dhanji dhanji Awaiting requested review from dhanji

@wesbillman wesbillman Awaiting requested review from wesbillman

@worstell worstell Awaiting requested review from worstell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt2e @alecthomas