feat(go-runtime): use new configuration/secret system #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/configuration-go-runtime
branch
5 times, most recently
from
e5f0fe2 to
56dbfad
Compare
alecthomas
commented
Mar 4, 2024
| @@ -218,6 +219,7 @@ func (s *Service) Deploy(ctx context.Context, req *connect.Request[ftlv1.DeployR | |||
| ftlv1connect.NewVerbServiceClient, | |||
| plugin.WithEnvars( | |||
| "FTL_ENDPOINT="+s.config.ControllerEndpoint.String(), | |||
| "FTL_CONFIG="+filepath.Join(internal.GitRoot(""), "ftl-project.toml"), | |||
There was a problem hiding this comment.
This is hard coded to look in the git root for now. Once the runner/controller implements the second half of the config/secrets design, this will be less janky.
alecthomas
force-pushed
the
aat/configuration-go-runtime
branch
from
56dbfad to
7ff82d6
Compare
This allows secrets/config to be dynamically updated in most cases
(the envar provider being a notable exception).
```
🐚 ~/dev/ftl $ ftl config set echo.default --inline "anonymous"
🐚 ~/dev/ftl $ ftl config get echo.default
"anonymous"
🐚 ~/dev/ftl $ ftl call echo.echo aat/configuration-go-runtime
{"message":"Hello, anonymous!!! It is 2024-03-03 07:45:21.237088 +1000 AEST!"}
🐚 ~/dev/ftl $ ftl config set echo.default --inline "Anne"
🐚 ~/dev/ftl $ ftl config get echo.default
"Anne"
🐚 ~/dev/ftl $ ftl call echo.echo
{"message":"Hello, Anne!!! It is 2024-03-03 07:44:52.2176 +1000 AEST!"}
```
Also made a few tweaks to allow FTL to largely work offline:
- Propagate `replace` directives from Go modules into the generated main
and external-module `go.mod` files.
- Add `--[no-]console` flag that allows building of the console to be
skipped.
- Put Bit maven builds into offline mode (does not work fully, I think
there's another flag to force Maven to use the local repository that
needs to be used, but I'm offline and there's nothing in `--help`).
alecthomas
force-pushed
the
aat/configuration-go-runtime
branch
from
7ff82d6 to
1f63c29
Compare
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows secrets/config to be dynamically updated in most cases (the envar provider being a notable exception).
I also refactored the
configurationpackage such that managers and providers are tied to their role by a type parameter.Finally, I made a few tweaks to allow FTL to largely work offline:
replacedirectives from Go modules into the generated main and external-modulego.modfiles.--[no-]consoleflag that allows building of the console to be skipped.