Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calls to timeline for p2p routing #3669

Closed
matt2e opened this issue Dec 8, 2024 · 0 comments · Fixed by #3687
Closed

Add calls to timeline for p2p routing #3669

matt2e opened this issue Dec 8, 2024 · 0 comments · Fixed by #3687
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Dec 8, 2024

No description provided.

@matt2e matt2e self-assigned this Dec 8, 2024
@ftl-robot ftl-robot mentioned this issue Dec 8, 2024
Open
@matt2e matt2e mentioned this issue Dec 9, 2024
Merged
3 tasks
matt2e added a commit that referenced this issue Dec 10, 2024
@matt2e @github-actions
feat: publish to timeline and telemetry when calling via p2p routing (#…
17409f6 
…3687)

- [x] Runner -> runner routing
- [x] `VerbCallRouter` for everything else
- [x] Provide timeline endpoint and attach timeline client to ctx in
each service that does p2p routing

Runners now need to know the deployment they are routing to to record
events properly.
Previously, routing in the deployment context only mapped module to
endpoint. I've changed this to pass along deployment instead.

Also fixes as issue where runners would keep old verb clients around
pointing to the original endpoint for a module even if it had since
changed.

closes #3669

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: publish to timeline and telemetry when calling via p2p routing block/ftl
1 participant
@matt2e