Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"failed to remove old deployment" results in busy loop #2885

Closed
alecthomas opened this issue Sep 28, 2024 · 0 comments · Fixed by #2920
Closed

"failed to remove old deployment" results in busy loop #2885

alecthomas opened this issue Sep 28, 2024 · 0 comments · Fixed by #2920
Labels
bug Something isn't working P3

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Sep 28, 2024

Saw a weird error when starting ftl dev without --recreate, and then ftl seemed to busy loop trying to allocate ports:

error:time:localScaling: Runner failed: failed to remove old deployment: unlinkat /Users/alec/Library/Caches/ftl-runner/runner2/deployments/time/dpl-time-r4mrnsiwffhbs0t/ftl/temp.txt: permission denied: failed to remove old deployment: unlinkat /Users/alec/Library/Caches/ftl-runner/runner2/deployments/time/dpl-time-r4mrnsiwffhbs0t/ftl/temp.txt: permission denied

No idea what temp.txt is or why it couldn't be removed.

Attached profile here.

Screenshot of profile:
image

Must be some MacOS thing creating the temp.txt files, perhaps to do with GCing the cache directory.

🐚 ~/dev/ftl $ ls -l /Users/alec/Library/Caches/ftl-runner/runner2/deployments/time/dpl-time-r4mrnsiwffhbs0t/ftl/temp.txt
-rw-r--r--  1 root  staff  0 26 Jul 14:49 /Users/alec/Library/Caches/ftl-runner/runner2/deployments/time/dpl-time-r4mrnsiwffhbs0t/ftl/temp.txt

But FTL still shouldn't go into a busy loop if this happens :. It seems to happen after suspend/resume.

@alecthomas alecthomas added the bug Something isn't working label Sep 28, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Sep 28, 2024
@ftl-robot ftl-robot mentioned this issue Sep 28, 2024
@gak gak added P1 P3 and removed triage Issue needs triaging P1 labels Sep 30, 2024
stuartwdouglas added a commit that referenced this issue Oct 1, 2024
Failure to remove old deployments should not be a fatal error.

fixes: #2885
stuartwdouglas added a commit that referenced this issue Oct 1, 2024
Failure to remove old deployments should not be a fatal error.

fixes: #2885
stuartwdouglas added a commit that referenced this issue Oct 1, 2024
Failure to remove old deployments should not be a fatal error.

fixes: #2885
stuartwdouglas added a commit that referenced this issue Oct 1, 2024
Failure to remove old deployments should not be a fatal error.

fixes: #2885
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working P3
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants