Skip to content

Commit

Permalink
fix: prevent possible busy loop
Browse files Browse the repository at this point in the history
Failure to remove old deployments should not be a fatal error.

fixes: #2885
  • Loading branch information
stuartwdouglas committed Oct 1, 2024
1 parent 5bac043 commit 43cd92e
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion backend/runner/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ func manageDeploymentDirectory(logger *log.Logger, config Config) error {

err := os.RemoveAll(old)
if err != nil {
return fmt.Errorf("failed to remove old deployment: %w", err)
// This is not a fatal error, just log it.
logger.Errorf(err, "Failed to remove old deployment: %s", deployment.Name())
}
}
}
Expand Down

0 comments on commit 43cd92e

Please sign in to comment.