generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Evaluate and implement TanStack table #2460
Comments
Open
Open
From a brief glance: Pros:
Cons:
Notes from quick sync:
|
For the future: this is a nice table alternative if we want to use a library: https://www.ag-grid.com/react-data-grid/getting-started/ |
Fixing alignment of flex-width columns: #2463 |
This was referenced Aug 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this issue
Aug 20, 2024
…#2464) Set min width on console's calls table to prevent tbody rows from getting chopped. Steps to reproduce: 1. Make browser window so small that the table cannot fit 1. Scroll to the table all the way to the right to see the full Error column 1. Observe how the border lies too far to the left, chopping off the contents of the table below the header. <img width="199" alt="Screenshot 2024-08-20 at 4 35 17 PM" src="https://github.com/user-attachments/assets/845de044-f3a8-45e8-a4eb-d784e83ca7c1"> Before fix: <img width="194" alt="Screenshot 2024-08-20 at 4 35 40 PM" src="https://github.com/user-attachments/assets/69eea725-61ca-4d00-95a6-dec11171c59c"> Issue: #2460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The tables in the console have lots of little UX issues. We should look into integrating TanStack table (or something else awesome) so that we can avoid many of the common table issues.
The text was updated successfully, but these errors were encountered: