Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate and implement TanStack table #2460

Closed
wesbillman opened this issue Aug 20, 2024 · 3 comments
Closed

Evaluate and implement TanStack table #2460

wesbillman opened this issue Aug 20, 2024 · 3 comments
Assignees
Labels
console Web console dx

Comments

@wesbillman
Copy link
Collaborator

The tables in the console have lots of little UX issues. We should look into integrating TanStack table (or something else awesome) so that we can avoid many of the common table issues.

@wesbillman wesbillman added console Web console dx labels Aug 20, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Aug 20, 2024
@ftl-robot ftl-robot mentioned this issue Aug 20, 2024
@deniseli
Copy link
Contributor

deniseli commented Aug 20, 2024

From a brief glance:

Pros:

Cons:

  • Built to be used with the <table> element type, which is severely limiting:
    • Render slower, to an extent that's incredibly problematic for full-page tables with many rows and more complex content. Related: lazy loading tends to work pretty poorly with dynamic re-rendering of rows in a <table>, or at least I've never personally found a workaround.
    • Limits formatting to a really basic grid. Frustrating to interleave intermediate rows (e.g. section headers, click-to-expand blocks) without aggressive CSS hacks that can get horrendous to maintain.

Notes from quick sync:

  • Current tables in the console are actual <table>s, not divs.
  • We're mainly interested in ironing out some layout bugs with the existing table displays
  • I'll take a quick look at whether tanstack helps with any of that, but mostly expecting that whether we use tanstack or not, we'll need to fix the layout issues with some CSS
  • I'll take a quick pass at fixing the current bugs with CSS.
  • We'll want to redesign the deployments page, including possibly the inflow UX to the page (e.g. start with modules?)

@github-actions github-actions bot removed the triage Issue needs triaging label Aug 20, 2024
@deniseli
Copy link
Contributor

For the future: this is a nice table alternative if we want to use a library: https://www.ag-grid.com/react-data-grid/getting-started/

@deniseli
Copy link
Contributor

Fixing alignment of flex-width columns: #2463

github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
…#2464)

Set min width on console's calls table to prevent tbody rows from
getting chopped.

Steps to reproduce:
1. Make browser window so small that the table cannot fit
1. Scroll to the table all the way to the right to see the full Error
column
1. Observe how the border lies too far to the left, chopping off the
contents of the table below the header.

<img width="199" alt="Screenshot 2024-08-20 at 4 35 17 PM"
src="https://github.com/user-attachments/assets/845de044-f3a8-45e8-a4eb-d784e83ca7c1">

Before fix:
<img width="194" alt="Screenshot 2024-08-20 at 4 35 40 PM"
src="https://github.com/user-attachments/assets/69eea725-61ca-4d00-95a6-dec11171c59c">

Issue: #2460
github-merge-queue bot pushed a commit that referenced this issue Aug 20, 2024
…tables (#2465)

The Content column in the timeline table can be truncated when the
browser window is small, but doesn't display its contents on hover.

#2460

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
console Web console dx
Projects
None yet
Development

No branches or pull requests

2 participants