Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op (1password) tries to be executed when calling unrelated commands #2090

Closed
gak opened this issue Jul 17, 2024 · 2 comments · Fixed by #2093
Closed

op (1password) tries to be executed when calling unrelated commands #2090

gak opened this issue Jul 17, 2024 · 2 comments · Fixed by #2093
Assignees

Comments

@gak
Copy link
Contributor

gak commented Jul 17, 2024

This is on a new empty project with ftl-controller running.

root@ftl:~# ./ftl --endpoint http://192.168.194.12:8892 --log-level trace status
trace: /xyz.block.ftl.v1.AdminService/Ping (unary)
error: Error syncing op: 1Password CLI tool "op" not found: exec: "op": executable file not found in $PATH
trace: /xyz.block.ftl.v1.ControllerService/Status (unary)
{
  "controllers": [
    {
      "key": "ctr-192.168.194.12-8892-3ri1n50t96yacpy3",
      "version": "0.296.0"
    }
  ]
}
@github-actions github-actions bot added the triage Issue needs triaging label Jul 17, 2024
@ftl-robot ftl-robot mentioned this issue Jul 17, 2024
@gak gak changed the title op (1password) tries to be executed when calling status op (1password) tries to be executed when calling unrelated commands Jul 17, 2024
@gak
Copy link
Contributor Author

gak commented Jul 17, 2024

Maybe same as:

@matt2e
Copy link
Collaborator

matt2e commented Jul 17, 2024

Looks slightly different @gak
I've only been running this on a machine with op available, but we shouldn't log an error if the project doesnt use 1Password for secrets and they don't have op installed.

@matt2e matt2e self-assigned this Jul 17, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 17, 2024
@matt2e matt2e closed this as completed in 894b473 Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants