Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1Password spamming prompts again #2086

Closed
matt2e opened this issue Jul 16, 2024 · 0 comments · Fixed by #2091
Closed

1Password spamming prompts again #2086

matt2e opened this issue Jul 16, 2024 · 0 comments · Fixed by #2091
Assignees
@matt2e

Comments

@matt2e
Copy link
Collaborator

matt2e commented Jul 16, 2024

Happens after starting ftl dev with about ~12 prompts at first, and then more
@github-actions github-actions bot added the triage Issue needs triaging label Jul 16, 2024
@ftl-robot ftl-robot mentioned this issue Jul 16, 2024
Open
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 16, 2024
@gak gak mentioned this issue Jul 17, 2024
Closed
@matt2e matt2e mentioned this issue Jul 17, 2024
Merged
matt2e added a commit that referenced this issue Jul 17, 2024
@matt2e
fix: only create config managers if needed to avoid syncing on every …
1e695b0 
…cmd (#2091)

fixes #2086
- Recently we added a feature for cf.Manager to sync providers
(1Password & ASM)
- We should not create these managers if they are not used, otherwise we
will prompt the user for 1Password access unnecessarily
- Previously we were creating config + secret managers in `main.go` for
every command, even though it is only needed for these commands:
    - `ftl serve`
    - `ftl dev`
    - `ftl config ...` if there is no controller running
    - `ftl secret ...` if there is no controller running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matt2e matt2e

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: only create config managers if needed to avoid syncing on every cmd block/ftl
1 participant
@matt2e