Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If FTL can't start for some reason, attempting to start it again results in failure to start + icon spinning #1890

Closed
alecthomas opened this issue Jun 27, 2024 · 1 comment · Fixed by #1934
Closed

If FTL can't start for some reason, attempting to start it again results in failure to start + icon spinning #1890

alecthomas opened this issue Jun 27, 2024 · 1 comment · Fixed by #1934
Assignees
@gak
Labels
bug Something isn't working extension Issues related to our VSCode extension P1

Comments

@alecthomas
Copy link
Collaborator

alecthomas commented Jun 27, 2024 •
edited
Loading

The first start failed because PG was hosed. The second attempt failed with the following message, and the spinner just kept spinning forever. I had to restart.

image
@alecthomas alecthomas added bug Something isn't working extension Issues related to our VSCode extension labels Jun 27, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 27, 2024
@ftl-robot ftl-robot mentioned this issue Jun 27, 2024
Open
@matt2e matt2e added the next Work that will be be picked up next label Jul 1, 2024
@github-actions github-actions bot removed the triage Issue needs triaging label Jul 1, 2024
@matt2e matt2e added the P1 label Jul 1, 2024
@gak
Copy link
Contributor

gak commented Jul 2, 2024

Related, my attempt shows successfully built when intentionally crashing on startup:

image image

@gak gak self-assigned this Jul 2, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jul 2, 2024
@gak gak mentioned this issue Jul 2, 2024
Merged
@gak gak closed this as completed in #1934 Jul 2, 2024
@gak gak closed this as completed in 2fd15ac Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gak gak

Labels
bug Something isn't working extension Issues related to our VSCode extension P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(vscode): handle lsp crashes block/ftl
3 participants
@gak @alecthomas @matt2e