Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ftl dev and ftl serve should error if no ftl-project.toml file is found (or specified) #1669

Closed
wesbillman opened this issue Jun 5, 2024 · 0 comments · Fixed by #1759
Closed

ftl dev and ftl serve should error if no ftl-project.toml file is found (or specified) #1669

wesbillman opened this issue Jun 5, 2024 · 0 comments · Fixed by #1759
Assignees
@safeer
Labels
good first issue Good for newcomers

Comments

@wesbillman
Copy link
Collaborator

We want to require the usage of ftl-project.toml files now.

The user can override this with --config=<custom>-project.toml, but ftl dev and ftl serve should error if no project file is provided (or automatically detected)
@wesbillman wesbillman added the good first issue Good for newcomers label Jun 5, 2024
@github-actions github-actions bot added the triage Issue needs triaging label Jun 5, 2024
@ftl-robot ftl-robot mentioned this issue Jun 5, 2024
Open
@alecthomas alecthomas added next Work that will be be picked up next and removed triage Issue needs triaging labels Jun 6, 2024
@safeer safeer self-assigned this Jun 10, 2024
@github-actions github-actions bot removed the next Work that will be be picked up next label Jun 10, 2024
@safeer safeer mentioned this issue Jun 11, 2024
Closed
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
ab5d581 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
832e359 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
@alecthomas alecthomas mentioned this issue Jun 13, 2024
Merged
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
4fc42a6 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
bc5d490 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
06f4b76 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
90040a2 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file
820d896 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Fixes #1669
alecthomas added a commit that referenced this issue Jun 13, 2024
@alecthomas
fix: require an ftl-project.toml file (#1759)
5372a00 
This is a global requirement across all commands, not scoped
specifically to `ftl serve` or `ftl dev`, because eg. `ftl secret`/`ftl
config`, etc. etc. all require this config file, and it's just
cleaner/safer to do it in one location.

Also fixed soooooo many bugs!

Fixes #1669
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@safeer safeer

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
3 participants
@alecthomas @wesbillman @safeer