Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor go-runtime schema extraction #1518

Closed
worstell opened this issue May 16, 2024 · 0 comments · Fixed by #2171
Closed

refactor go-runtime schema extraction #1518

worstell opened this issue May 16, 2024 · 0 comments · Fixed by #2171
Assignees
@worstell

Comments

@worstell
Copy link
Contributor

worstell commented May 16, 2024 •
edited
Loading

this file has gotten out of hand!!!!
it's quite difficult to reason through

refactor will split out schema concepts into separate scans (e.g. parse type enums, parse value enums, parse verbs, etc.)

reference https://pkg.go.dev/golang.org/x/tools/go/analysis
@worstell worstell self-assigned this May 16, 2024
@ftl-robot ftl-robot mentioned this issue May 16, 2024
Open
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
547b242 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
55fc9f8 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
@worstell worstell mentioned this issue Jun 7, 2024
Merged
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
1fac550 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
4546309 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
751069c 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
0f2c7ec 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
7850af9 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
155742f 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
1216cd2 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
a51bf8c 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
6ecedcd 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction
cb33912 
initial step towards #1518

- integrates with (forked) go/analysis to run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
worstell added a commit that referenced this issue Jun 7, 2024
@worstell
chore: refactor go schema extraction (#1700)
21930e3 
initial step towards #1518

- integrates with
([forked](https://github.com/TBD54566975/golang-tools)) go/analysis to
run static analysis tasks for schema extraction
- implements first extraction task, type aliases
- refactors existing build stack to use the new extractor, combining
results with legacy so we can incrementally migrate
- removes typealias extraction logic from legacy code
@worstell worstell mentioned this issue Jun 8, 2024
Merged
worstell added a commit that referenced this issue Jun 17, 2024
@worstell
chore: migrate verb schema parsing (#1711)
15b653f 
restructuring and adding some additional passes to provide data for the
extractors-
1. metadata pass parses all comments in the packages and provides
results via facts
2. transitive pass extracts nodes marked as needing extraction via
implicit reference from other decls

#1518
worstell added a commit that referenced this issue Jul 25, 2024
@worstell
feat: finish migrating schema extractiongit loggit log
4854d20 
- migrates FSMs to new extractor
- deletes legacy code

fixes #1518
worstell added a commit that referenced this issue Jul 25, 2024
@worstell
feat: finish migrating schema extraction!!!!
6449427 
- migrates FSMs to new extractor
- deletes legacy code

fixes #1518
@worstell worstell mentioned this issue Jul 25, 2024
Merged
worstell added a commit that referenced this issue Jul 25, 2024
@worstell
feat: finish migrating schema extraction!!!!
fa94aeb 
- migrates FSMs to new extractor
- deletes legacy code

fixes #1518
worstell added a commit that referenced this issue Jul 25, 2024
@worstell
feat: finish migrating schema extraction!!!!
9b3e5f6 
- migrates FSMs to new extractor
- deletes legacy code

fixes #1518
worstell added a commit that referenced this issue Jul 25, 2024
@worstell
feat: finish migrating schema extraction!!!!
6f44efb 
- migrates FSMs to new extractor
- deletes legacy code

fixes #1518
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: finish migrating schema extraction!!!! block/ftl
1 participant
@worstell