Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse a module that has more than 2 lines of comments for a Secret causes a parse error #1507

Closed
gak opened this issue May 16, 2024 · 0 comments · Fixed by #1510
Closed

Parse a module that has more than 2 lines of comments for a Secret causes a parse error #1507

gak opened this issue May 16, 2024 · 0 comments · Fixed by #1510
Labels
good first issue Good for newcomers triage Issue needs triaging

Comments

@gak
Copy link
Contributor

gak commented May 16, 2024

Saw this in TestParseModule when working on #1505 but didn't investigate.

// A comment
module todo {
  // A config value
  config configValue String
  // Shhh
  // This is a secret
  // It should not be shared
  secret secretValue String
schema_test.go:459: Did not expect an error but got:
        9:3: unexpected token "secret" (expected "data" <ident> ("<" TypeParameter ("," TypeParameter)* ">")? "{" Field* "}" Metadata*)
@gak gak added good first issue Good for newcomers triage Issue needs triaging labels May 16, 2024
@ftl-robot ftl-robot mentioned this issue May 16, 2024
@gak gak changed the title Parse module doesn's support more than 2 lines of comments for a Secret Parse a module that has more than 2 lines of comments for a Secret causes a parse error May 16, 2024
alecthomas added a commit that referenced this issue May 16, 2024
Fixes #1507. I'm really surprised we haven't hit this previously.
alecthomas added a commit that referenced this issue May 16, 2024
Fixes #1507. I'm really surprised we haven't hit this previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers triage Issue needs triaging
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant