generated from TBD54566975/tbd-project-template
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow module tests to be run from VS Code #1502
Labels
good first issue
Good for newcomers
Comments
from discussion with @mistermoe |
Open
The current logic when running
|
In fact we should probably use |
good first issue? |
wesbillman
added
good first issue
Good for newcomers
and removed
triage
Issue needs triaging
labels
May 16, 2024
safeer
added a commit
that referenced
this issue
May 21, 2024
Fixes #1502. Adds tests to ensure we're correctly falling back to the config in `FTL_CONFIG` and to `ftl-project.toml` in the gitroot.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We are close to having module unit tests work within VS Code. This will also make it easy to debug module code/tests.
The only thing missing is that
ftltest.WithProjectFiles()
relies onFTL_CONFIG
envar.Workarounds:
code .
Both of these are annoying because you have to make sure you don't commit the changes because the path includes your home directory.
Possible solution:
We switch logic to look for expected file names in the current folder, if missing go up a level ... repeat.
This is similar to how you can call
just
from anywhere within the directory structureWe could make FTL_CONFIG and ftltest.WithProjectFiles(...) do this. This would make passing in strings to the test function actually usable in more cases, and the ftl config value to be able to be commited to git
The text was updated successfully, but these errors were encountered: