Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add database type to the schema #1306

Closed
worstell opened this issue Apr 18, 2024 · 1 comment · Fixed by #1374
Closed

add database type to the schema #1306

worstell opened this issue Apr 18, 2024 · 1 comment · Fixed by #1374
Assignees
@worstell

Comments

@worstell
Copy link
Contributor

No description provided.

@worstell worstell self-assigned this Apr 18, 2024
@alecthomas alecthomas mentioned this issue Apr 18, 2024
Open
@matt2e matt2e mentioned this issue Apr 18, 2024
Closed
@alecthomas
Copy link
Collaborator

Not sure this is a good idea but we could type parameterise the function too so instead of PostgresDatabase and MySQLDatabase it would be ftl.Database[ftl.Postgres]

worstell added a commit that referenced this issue May 1, 2024
@worstell
feat: add database type to the schema
58b9353 
fixes #1306
worstell added a commit that referenced this issue May 1, 2024
@worstell
feat: add database type to the schema
fce2b9b 
fixes #1306
@worstell worstell mentioned this issue May 1, 2024
Merged
worstell added a commit that referenced this issue May 1, 2024
@worstell
feat: add database type to the schema (#1374)
223151a 
fixes #1306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@worstell worstell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add database type to the schema block/ftl
2 participants
@alecthomas @worstell