Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schema should include type for databases #1307

Closed
matt2e opened this issue Apr 18, 2024 · 1 comment
Closed

Schema should include type for databases #1307

matt2e opened this issue Apr 18, 2024 · 1 comment
Labels
triage Issue needs triaging

Comments

@matt2e
Copy link
Collaborator

matt2e commented Apr 18, 2024

ftl package's db getter defines the type (ftl.PostgresDatabase(name string)) but the schema would not hold the type.

This is a problem because we do not know what type of db to initialize when go-runtime is reading in DSNs (which is currently a work in progress).
@github-actions github-actions bot added the triage Issue needs triaging label Apr 18, 2024
@alecthomas alecthomas mentioned this issue Apr 18, 2024
Open
@matt2e
Copy link
Collaborator Author

matt2e commented Apr 18, 2024

Dupe of #1306

@matt2e matt2e closed this as completed Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Issue needs triaging
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matt2e