move source plugin to a release profile

block · Sep 10, 2024 · fdc8e42 · fdc8e42
1 parent 929024f
commit fdc8e42
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 12 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -164,7 +164,7 @@ jobs:
           # Maven deploy lifecycle will build, run tests, verify, sign, and deploy
           mvn \
             deploy \
-              -P ossrh,sign-artifacts \
+              -P ossrh,release \
               --batch-mode \
               --settings .maven_settings.xml
         env:

diff --git a/jvm-runtime/ftl-runtime/pom.xml b/jvm-runtime/ftl-runtime/pom.xml
@@ -273,11 +273,6 @@
             </plugins>
         </pluginManagement>
         <plugins>
-            <!-- generates a JAR file containing the source code of the project -->
-            <plugin>
-                <groupId>org.apache.maven.plugins</groupId>
-                <artifactId>maven-source-plugin</artifactId>
-            </plugin>
             <!-- handles the deployment of the project's artifacts to a remote repository -->
             <plugin>
                 <groupId>org.apache.maven.plugins</groupId>
@@ -368,19 +363,22 @@
                 </plugins>
             </build>
         </profile>
-        <!-- used to sign artifacts during the build process. It activates the sign-maven-plugin, 
-             which automatically signs the project's artifacts. This is typically required when 
-             deploying to Maven Central or other repositories that mandate signed artifacts for 
-             security and authenticity verification. Activate this profile when you need to create 
-             signed releases, usually in conjunction with the deployment to public repositories. -->
+
         <profile>
-            <id>sign-artifacts</id>
+            <!-- Profile for releasing artifacts to Maven Central -->
+            <id>release</id>
             <build>
                 <plugins>
+                    <!-- produce signed artifacts -->
                     <plugin>
                         <groupId>org.simplify4u.plugins</groupId>
                         <artifactId>sign-maven-plugin</artifactId>
                     </plugin>
+                    <!-- generates a JAR file containing the source code of the project -->
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-source-plugin</artifactId>
+                    </plugin>
                 </plugins>
             </build>
         </profile>