refactor: replace inmemoryprovider with inlineprovider (#1348)

In-memory provider was being used to hold config and secrets in memory, but inline provider already solved that. Removing to simplify things
block · Apr 28, 2024 · f8ce99d · f8ce99d
1 parent 4f8a992
commit f8ce99d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 46 deletions.
diff --git a/common/configuration/in_memory_provider.go b/common/configuration/in_memory_provider.go
diff --git a/go-runtime/modulecontext/from_proto.go b/go-runtime/modulecontext/from_proto.go
@@ -33,7 +33,9 @@ func FromProto(ctx context.Context, response *ftlv1.ModuleContextResponse) (*Mod
 }
 
 func newInMemoryConfigManager[R cf.Role](ctx context.Context, config map[string][]byte) (*cf.Manager[R], error) {
-	provider := cf.NewInMemoryProvider[R]()
+	provider := cf.InlineProvider[R]{
+		Inline: true,
+	}
 	refs := map[cf.Ref]*url.URL{}
 	for name, data := range config {
 		ref := cf.Ref{Name: name}

diff --git a/go-runtime/modulecontext/module_context_test.go b/go-runtime/modulecontext/module_context_test.go
@@ -21,13 +21,17 @@ func TestConfigPriority(t *testing.T) {
 
 	moduleName := "test"
 
-	cp := cf.NewInMemoryProvider[cf.Configuration]()
+	cp := cf.InlineProvider[cf.Configuration]{
+		Inline: true,
+	}
 	cr := cf.NewInMemoryResolver[cf.Configuration]()
 	cm, err := cf.New(ctx, cr, []cf.Provider[cf.Configuration]{cp})
 	assert.NoError(t, err)
 	ctx = cf.ContextWithConfig(ctx, cm)
 
-	sp := cf.NewInMemoryProvider[cf.Secrets]()
+	sp := cf.InlineProvider[cf.Secrets]{
+		Inline: true,
+	}
 	sr := cf.NewInMemoryResolver[cf.Secrets]()
 	sm, err := cf.New(ctx, sr, []cf.Provider[cf.Secrets]{sp})
 	assert.NoError(t, err)