adopting PR feedback

backend/controller/dal/fsm.go

@@ -59,28 +59,28 @@ func (d *DAL) StartFSMTransition(ctx context.Context, fsm schema.RefKey, executi
 		return fmt.Errorf("failed to start FSM transition: %w", err)
 	}
 	if instance.CreatedAt.Equal(instance.UpdatedAt) {
-		observability.FSM().InstanceCreated(ctx, fsm)
+		observability.FSM.InstanceCreated(ctx, fsm)
 	}
-	observability.FSM().TransitionStarted(ctx, fsm, destinationState)
+	observability.FSM.TransitionStarted(ctx, fsm, destinationState)
 	return nil
 }
 
 func (d *DAL) FinishFSMTransition(ctx context.Context, fsm schema.RefKey, instanceKey string) error {
 	_, err := d.db.FinishFSMTransition(ctx, fsm, instanceKey)
-	observability.FSM().TransitionCompleted(ctx, fsm)
+	observability.FSM.TransitionCompleted(ctx, fsm)
 
 	return dalerrs.TranslatePGError(err)
 }
 
 func (d *DAL) FailFSMInstance(ctx context.Context, fsm schema.RefKey, instanceKey string) error {
 	_, err := d.db.FailFSMInstance(ctx, fsm, instanceKey)
-	observability.FSM().InstanceCompleted(ctx, fsm)
+	observability.FSM.InstanceCompleted(ctx, fsm)
 	return dalerrs.TranslatePGError(err)
 }
 
 func (d *DAL) SucceedFSMInstance(ctx context.Context, fsm schema.RefKey, instanceKey string) error {
 	_, err := d.db.SucceedFSMInstance(ctx, fsm, instanceKey)
-	observability.FSM().InstanceCompleted(ctx, fsm)
+	observability.FSM.InstanceCompleted(ctx, fsm)
 	return dalerrs.TranslatePGError(err)
 }
 

backend/controller/dal/fsm_test.go

@@ -2,7 +2,6 @@ package dal
 
 import (
 	"context"
-	"github.com/TBD54566975/ftl/backend/controller/observability"
 	"testing"
 	"time"
 
@@ -16,8 +15,6 @@ import (
 )
 
 func TestSendFSMEvent(t *testing.T) {
-	_ = observability.InitControllerObservability()
-
 	ctx := log.ContextWithNewDefaultLogger(context.Background())
 	conn := sqltest.OpenForTesting(ctx, t)
 	dal, err := New(ctx, conn)

backend/controller/observability/fsm.go

@@ -25,7 +25,7 @@ type FSMMetrics struct {
 	transitionAttempts metric.Int64Counter
 }
 
-func InitFSMMetrics() (*FSMMetrics, error) {
+func initFSMMetrics() (*FSMMetrics, error) {
 	result := &FSMMetrics{}
 
 	var errs error

backend/controller/observability/observability.go

@@ -1,23 +1,19 @@
 package observability
 
-import "fmt"
+import (
+	"fmt"
+)
 
 var (
-	fsm *FSMMetrics
+	FSM *FSMMetrics
 )
 
-func InitControllerObservability() error {
+func init() {
 	var err error
 
-	fsm, err = InitFSMMetrics()
+	FSM, err = initFSMMetrics()
 
 	if err != nil {
-		return fmt.Errorf("could not initialize controller metrics: %w", err)
+		panic(fmt.Errorf("could not initialize controller metrics: %w\n", err))
 	}
-
-	return nil
-}
-
-func FSM() *FSMMetrics {
-	return fsm
 }