Skip to content

Commit

Permalink
fix: wait for dev endpoint to be available before runner is ready (#3794
Browse files Browse the repository at this point in the history
)

This became apparent when pubsub would immediately start trying to
consume events once the runner claimed to be ready.
  • Loading branch information
matt2e authored Dec 17, 2024
1 parent 5e49706 commit ca17408
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions backend/runner/runner.go
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,11 @@ func (s *Service) deploy(ctx context.Context, key model.DeploymentKey, module *s
logger.Errorf(err, "could not create FTL dev Config")
}
}
err = rpc.Wait(ctx, backoff.Backoff{}, time.Second*10, client)
if err != nil {
observability.Deployment.Failure(ctx, optional.Some(key.String()))
return fmt.Errorf("failed to ping dev endpoint: %w", err)
}
} else {
err := download.ArtefactsFromOCI(ctx, s.controllerClient, key, deploymentDir, s.storage)
if err != nil {
Expand Down

0 comments on commit ca17408

Please sign in to comment.