lint

cmd/ftl/cmd_serve.go

@@ -94,7 +94,7 @@ func (s *serveCmd) run(ctx context.Context, projConfig projectconfig.Config, ini
 
 	err = observability.Init(ctx, "ftl-serve", ftl.Version, s.ObservabilityConfig)
 	if err != nil {
-		return err
+		return fmt.Errorf("observability init failed: %w", err)
 	}
 
 	wg, ctx := errgroup.WithContext(ctx)

go-runtime/ftl/call.go

@@ -6,8 +6,6 @@ import (
 	"reflect"
 
 	"connectrpc.com/connect"
-	"go.opentelemetry.io/otel"
-	"go.opentelemetry.io/otel/metric"
 
 	ftlv1 "github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1"
 	"github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1/ftlv1connect"
@@ -19,20 +17,6 @@ import (
 )
 
 func call[Req, Resp any](ctx context.Context, callee reflection.Ref, req Req, inline Verb[Req, Resp]) (resp Resp, err error) {
-	// This is a test metric to make sure we actually propogate everything through the
-	// observability path correctly. In the future, errors should be tracked through
-	// otel logs instead of being swallowed as they are here. Error is swallowed to
-	// guarantee no impact to customers.
-	counter, err := otel.GetMeterProvider().Meter("ftl_verb_123").Int64Counter(
-		"verb_call",
-		metric.WithDescription("Count of FTL verb calls via the controller"),
-		metric.WithUnit("requests"))
-	if err != nil {
-		// log it
-	} else {
-		counter.Add(ctx, 1)
-	}
-
 	moduleCtx := modulecontext.FromContext(ctx).CurrentContext()
 	override, err := moduleCtx.BehaviorForVerb(schema.Ref{Module: callee.Module, Name: callee.Name})
 	if err != nil {