fix: don't allow spaces in vault names

block · May 21, 2024 · a7e5f23 · a7e5f23
1 parent a48a08e
commit a7e5f23
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/common/configuration/1password_provider.go b/common/configuration/1password_provider.go
@@ -58,6 +58,9 @@ func (o OnePasswordProvider) Store(ctx context.Context, ref Ref, value []byte) (
 	if err := checkOpBinary(); err != nil {
 		return nil, err
 	}
+	if strings.Contains(o.Vault, " ") {
+		return nil, fmt.Errorf("1Password vault name %q contains spaces, which is not supported", o.Vault)
+	}
 
 	var secret string
 	err := json.Unmarshal(value, &secret)

diff --git a/common/configuration/1password_provider_test.go b/common/configuration/1password_provider_test.go
@@ -1,6 +1,6 @@
 //go:build 1password
 
-// 1password needs to be running and have a vault named "ftl test".
+// 1password needs to be running and have a vault named "ftl-test".
 //
 // These tests will clean up before and after itself.
 
@@ -16,7 +16,7 @@ import (
 	"github.com/TBD54566975/ftl/internal/log"
 )
 
-const vault = "ftl test"
+const vault = "ftl-test"
 const module = "test.module"
 
 func clean(ctx context.Context) bool {