Skip to content

Commit

Permalink
feat: remove verb naming error
Browse files Browse the repository at this point in the history
added this in because we had it in the legacy extractor in a PR that was missed, but not sure about the rationale so would like to discuss before updating downstream customers to comply
  • Loading branch information
worstell committed Jul 12, 2024
1 parent ddeb24e commit 98bfe2b
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions go-runtime/schema/verb/analyzer.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,12 +63,6 @@ func Extract(pass *analysis.Pass, root *ast.FuncDecl, obj types.Object) optional
}

func checkSignature(pass *analysis.Pass, node *ast.FuncDecl, sig *types.Signature) (req, resp optional.Option[*types.Var]) {
if expVerbName := strcase.ToUpperCamel(node.Name.Name); node.Name.Name != expVerbName {
common.Errorf(pass, node, "unexpected verb name %q, did you mean to use %q instead?", node.Name.Name,
expVerbName)
return optional.None[*types.Var](), optional.None[*types.Var]()
}

params := sig.Params()
results := sig.Results()
if params.Len() > 2 {
Expand Down

0 comments on commit 98bfe2b

Please sign in to comment.