Skip to content

Commit

Permalink
chore: fix intellij errors (#2483)
Browse files Browse the repository at this point in the history
Having a go.mod file with a broken version makes Intellij throw constant
errors.

This fixes is by changing the name and renaming it back in a temp
directory as part of the test.
  • Loading branch information
stuartwdouglas authored Aug 24, 2024
1 parent 2d7277a commit 8b35120
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 252 deletions.
28 changes: 0 additions & 28 deletions internal/buildengine/build_go_test.go
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
package buildengine

import (
"fmt"
"os"
"runtime"
"testing"

"github.com/alecthomas/assert/v2"
Expand Down Expand Up @@ -47,32 +45,6 @@ func TestExternalType(t *testing.T) {
})
}

func TestGoModVersion(t *testing.T) {
if testing.Short() {
t.SkipNow()
}
sch := &schema.Schema{
Modules: []*schema.Module{
schema.Builtins(),
{Name: "highgoversion", Decls: []schema.Decl{
&schema.Data{Name: "EchoReq"},
&schema.Data{Name: "EchoResp"},
&schema.Verb{
Name: "echo",
Request: &schema.Ref{Name: "EchoRequest"},
Response: &schema.Ref{Name: "EchoResponse"},
},
}},
},
}
bctx := buildContext{
moduleDir: "testdata/highgoversion",
buildDir: ".ftl",
sch: sch,
}
testBuild(t, bctx, fmt.Sprintf("go version %q is not recent enough for this module, needs minimum version \"9000.1.1\"", runtime.Version()[2:]), "", []assertion{})
}

func TestGeneratedTypeRegistry(t *testing.T) {
if testing.Short() {
t.SkipNow()
Expand Down
13 changes: 0 additions & 13 deletions internal/buildengine/discover_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -137,19 +137,6 @@ func TestDiscoverModules(t *testing.T) {
},
},
},
{
Config: moduleconfig.ModuleConfig{
Dir: "testdata/highgoversion",
Language: "go",
Realm: "home",
Module: "highgoversion",
Deploy: []string{"main"},
DeployDir: ".ftl",
Schema: "schema.pb",
Errors: "errors.pb",
Watch: []string{"**/*.go", "go.mod", "go.sum", "../../../../go-runtime/ftl/**/*.go"},
},
},
{
Config: moduleconfig.ModuleConfig{
Dir: "testdata/integer",
Expand Down
2 changes: 0 additions & 2 deletions internal/buildengine/testdata/highgoversion/ftl.toml

This file was deleted.

46 changes: 0 additions & 46 deletions internal/buildengine/testdata/highgoversion/go.mod

This file was deleted.

142 changes: 0 additions & 142 deletions internal/buildengine/testdata/highgoversion/go.sum

This file was deleted.

21 changes: 0 additions & 21 deletions internal/buildengine/testdata/highgoversion/highgoversion.go

This file was deleted.

0 comments on commit 8b35120

Please sign in to comment.