fix: gracefully handle context cancelation when polling deployments (#…

…2127)
block · Jul 22, 2024 · 837eae1 · 837eae1
1 parent 8767717
commit 837eae1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/backend/controller/dal/notify.go b/backend/controller/dal/notify.go
@@ -84,7 +84,11 @@ func (d *DAL) PollDeployments(ctx context.Context) {
 
 		deployments, err := d.GetDeploymentsWithMinReplicas(ctx)
 		if err != nil {
-			logger.Errorf(err, "failed to get deployments")
+			if ctx.Err() == context.Canceled {
+				logger.Debugf("Polling stopped: %v", ctx.Err())
+				return
+			}
+			logger.Errorf(err, "failed to get deployments when polling")
 			time.Sleep(retry.Duration())
 			continue
 		}