Skip to content

Commit

Permalink
fix: one goroutine was waiting on a channel, blocking the waitgroup (#…
Browse files Browse the repository at this point in the history
…1910)

This prevented startup failures from being reported.
  • Loading branch information
alecthomas authored Jun 28, 2024
1 parent b5fbf19 commit 43d5a32
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion cmd/ftl/cmd_dev.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,11 @@ func (d *devCmd) Run(ctx context.Context, projConfig projectconfig.Config) error
}

g.Go(func() error {
<-controllerReady
select {
case <-ctx.Done():
return nil
case <-controllerReady:
}

opts := []buildengine.Option{buildengine.Parallelism(d.Parallelism)}
if d.Lsp {
Expand Down

0 comments on commit 43d5a32

Please sign in to comment.