chore: move resource outputs in a separate message (#2741)

backend/protos/xyz/block/ftl/v1beta1/provisioner/resource.proto

@@ -18,17 +18,20 @@ message Resource {
 
 // Resource types
 //
-// we use convention of prefixing field names with out_ if they are populated
-// after being provisioned by the provisioning engine
+// any output created by the provisioner is stored in a field called "output"
 
 message PostgresResource {
-  // fields populated after the resource has been created
-  string out_read_endpoint = 101;
-  string out_write_endpoint = 102;
+  message PostgresResourceOutput {
+    string read_endpoint = 1;
+    string write_endpoint = 2;
+  }
+  PostgresResourceOutput output = 1;
 }
 
 message MysqlResource {
-  // fields populated after the resource has been created
-  string out_read_endpoint = 101;
-  string out_write_endpoint = 102;
+  message MysqlResourceOutput {
+    string read_endpoint = 1;
+    string write_endpoint = 2;
+  }
+  MysqlResourceOutput output = 1;
 }

cmd/ftl-provisioner-cloudformation/status.go

@@ -103,16 +103,16 @@ func updateResources(outputs []types.Output, update []*provisioner.Resource) err
 				if postgres, ok := resource.Resource.(*provisioner.Resource_Postgres); ok {
 					switch key.PropertyName {
 					case PropertyDBReadEndpoint:
-						postgres.Postgres.OutReadEndpoint = *output.OutputValue
+						postgres.Postgres.Output.ReadEndpoint = *output.OutputValue
 					case PropertyDBWriteEndpoint:
-						postgres.Postgres.OutWriteEndpoint = *output.OutputValue
+						postgres.Postgres.Output.WriteEndpoint = *output.OutputValue
 					}
 				} else if mysql, ok := resource.Resource.(*provisioner.Resource_Mysql); ok {
 					switch key.PropertyName {
 					case PropertyDBReadEndpoint:
-						mysql.Mysql.OutReadEndpoint = *output.OutputValue
+						mysql.Mysql.Output.ReadEndpoint = *output.OutputValue
 					case PropertyDBWriteEndpoint:
-						mysql.Mysql.OutWriteEndpoint = *output.OutputValue
+						mysql.Mysql.Output.WriteEndpoint = *output.OutputValue
 					}
 				}
 			}