Skip to content

Commit

Permalink
feat: make filter panel sticky to the top of the page (#398)
Browse files Browse the repository at this point in the history
Fixes #389 
<img width="1538" alt="Screenshot 2023-09-18 at 12 10 26 PM"
src="https://github.com/TBD54566975/ftl/assets/51647/e5a4b025-9616-444c-924f-696e71485937">
  • Loading branch information
wesbillman authored Sep 18, 2023
1 parent 8d0b912 commit 348ac4a
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
8 changes: 5 additions & 3 deletions console/client/src/features/timeline/TimelinePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@ export const TimelinePage = () => {
<PageHeader icon={<ListBulletIcon />} title='Events'>
<TimelineTimeControls onTimeSettingsChange={handleTimeSettingsChanged} />
</PageHeader>
<div className='flex h-full'>
<TimelineFilterPanel onFiltersChanged={handleFiltersChanged} />
<div className='flex-grow'>
<div className='flex' style={{ height: 'calc(100% - 44px)' }}>
<div className='sticky top-0 flex-none overflow-y-auto'>
<TimelineFilterPanel onFiltersChanged={handleFiltersChanged} />
</div>
<div className='flex-grow overflow-y-scroll'>
<Timeline timeSettings={timeSettings} filters={filters} />
</div>
</div>
Expand Down
4 changes: 2 additions & 2 deletions console/client/src/layout/Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,8 @@ export const Layout = () => {
<div className='flex h-screen'>
<Navigation />

<main className='flex-1 overflow-hidden'>
<section className='overflow-y-auto h-full'>
<main className='flex-1 overflow-y-auto'>
<section className='h-full relative'>
<Outlet />
</section>
</main>
Expand Down

0 comments on commit 348ac4a

Please sign in to comment.