fix: stack trace exiting interactive console (#2786)

block · Sep 23, 2024 · 06a05f5 · 06a05f5
1 parent 164cb5b
commit 06a05f5
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/internal/console/status.go b/internal/console/status.go
@@ -119,8 +119,8 @@ func NewStatusManager(ctx context.Context) StatusManager {
 	}()
 
 	go func() {
-		defer sm.exitWait.Done()
 		current := ""
+		closed := false
 		for {
 
 			buf := bytes.Buffer{}
@@ -130,6 +130,9 @@ func NewStatusManager(ctx context.Context) StatusManager {
 				if current != "" {
 					sm.writeLine(current)
 				}
+				if !closed {
+					sm.exitWait.Done()
+				}
 				return
 			}
 			buf.Write(rawData[:n])
@@ -140,7 +143,10 @@ func NewStatusManager(ctx context.Context) StatusManager {
 					// we keep running though as there may be more data on exit
 					// that we handle on a best effort basis
 					sm.writeLine(current)
-					sm.exitWait.Done()
+					if !closed {
+						sm.exitWait.Done()
+						closed = true
+					}
 					continue
 				}
 				if err != nil {