Skip to content

Commit

Permalink
applying PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
jonathanj-square committed Oct 2, 2024
1 parent d323ff6 commit 01344b6
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion backend/controller/artefacts/dal_registry.go
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ type Service struct {
db sql.Querier
}

func New(_ context.Context, conn libdal.Connection) *Service {
func New(conn libdal.Connection) *Service {
return &Service{
db: sql.New(conn),
Handle: libdal.New(conn, func(h *libdal.Handle[Service]) *Service {
Expand Down
2 changes: 1 addition & 1 deletion backend/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ func New(ctx context.Context, conn *sql.DB, config Config, devel bool, runnerSca
pubSub := pubsub.New(conn, encryption, svc.tasks, optional.Some[pubsub.AsyncCallListener](svc))
svc.pubSub = pubSub

svc.registry = artefacts.New(ctx, conn)
svc.registry = artefacts.New(conn)

svc.dal = dal.New(ctx, conn, encryption, pubSub)

Expand Down
4 changes: 2 additions & 2 deletions backend/controller/dal/dal.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,15 +58,15 @@ func New(ctx context.Context, conn libdal.Connection, encryption *encryption.Ser
leaser: dbleaser.NewDatabaseLeaser(conn),
db: db,
encryption: encryption,
registry: aregistry.New(ctx, conn),
registry: aregistry.New(conn),
Handle: libdal.New(conn, func(h *libdal.Handle[DAL]) *DAL {
return &DAL{
Handle: h,
db: dalsql.New(h.Connection),
leaser: dbleaser.NewDatabaseLeaser(h.Connection),
pubsub: pubsub,
encryption: d.encryption,
registry: aregistry.New(ctx, h.Connection),
registry: aregistry.New(h.Connection),
DeploymentChanges: d.DeploymentChanges,
}
}),
Expand Down
4 changes: 2 additions & 2 deletions backend/controller/timeline/timeline_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ func TestTimeline(t *testing.T) {
assert.NoError(t, err)

timeline := New(ctx, conn, encryption)
registry := artefacts.New(ctx, conn)
registry := artefacts.New(conn)
scheduler := scheduledtask.New(ctx, model.ControllerKey{}, leases.NewFakeLeaser())
pubSub := pubsub.New(conn, encryption, scheduler, optional.None[pubsub.AsyncCallListener]())
controllerDAL := controllerdal.New(ctx, conn, encryption, pubSub)
Expand Down Expand Up @@ -223,7 +223,7 @@ func TestDeleteOldEvents(t *testing.T) {
assert.NoError(t, err)

timeline := New(ctx, conn, encryption)
registry := artefacts.New(ctx, conn)
registry := artefacts.New(conn)
scheduler := scheduledtask.New(ctx, model.ControllerKey{}, leases.NewFakeLeaser())
pubSub := pubsub.New(conn, encryption, scheduler, optional.None[pubsub.AsyncCallListener]())
controllerDAL := controllerdal.New(ctx, conn, encryption, pubSub)
Expand Down

0 comments on commit 01344b6

Please sign in to comment.