Skip to content

feat(go-runtime): extract FTL config/secret declarations as schema definitions #2533

feat(go-runtime): extract FTL config/secret declarations as schema definitions

feat(go-runtime): extract FTL config/secret declarations as schema definitions #2533

Triggered via pull request March 12, 2024 00:25
Status Failure
Total duration 2m 15s
Artifacts

ci.yml

on: pull_request
Matrix: Integration Tests / integration
Waiting for pending jobs
Auto Version  /  Conventional Commits Auto-version
Auto Version / Conventional Commits Auto-version
Fit to window
Zoom out
Zoom in

Annotations

10 errors
Proto Breaking Change Check: backend/protos/xyz/block/ftl/v1/schema/schema.proto#L252
Field "13" with name "verbRef" on message "Type" changed option "json_name" from "optional" to "verbRef".
Proto Breaking Change Check: backend/protos/xyz/block/ftl/v1/schema/schema.proto#L252
Field "13" on message "Type" changed type from "xyz.block.ftl.v1.schema.Optional" to "xyz.block.ftl.v1.schema.VerbRef".
Proto Breaking Change Check: backend/protos/xyz/block/ftl/v1/schema/schema.proto#L252
Field "13" on message "Type" changed name from "optional" to "verbRef".
Lint: go-runtime/compile/schema.go#L35
G101: Potential hardcoded credentials (gosec)
Lint: go-runtime/compile/schema.go#L208
type assertion must be checked (forcetypeassert)
Lint: go-runtime/compile/schema.go#L390
ineffectual assignment to ok (ineffassign)
Lint
Process completed with exit code 1.
Test Go: go-runtime/compile/schema_test.go#L71
=== RUN TestExtractModuleSchema module one { data Nested { } data Req { int Int int64 Int float Float string String slice [String] map {String: String} nested Nested optional Nested? time Time user two.User +alias json "u" bytes Bytes enumRef two.TwoEnum } data Resp { } verb verb(Req) Resp enum ColorInt(Int) { RedInt(0) BlueInt(1) GreenInt(2) RedInt(0) BlueInt(1) GreenInt(2) YellowInt(3) YellowInt(3) } enum SimpleIota(Int) { Zero(0) One(1) Two(2) Zero(0) One(1) Two(2) } enum IotaExpr(Int) { First(1) Second(3) Third(5) First(1) Second(3) Third(5) } enum Color(String) { Red("Red") Blue("Blue") Green("Green") Red("Red") Blue("Blue") Green("Green") Yellow("Yellow") Yellow("Yellow") } } go-runtime/compile/schema_test.go:71: Expected values to be equal: Red("Red") Blue("Blue") Green("Green") + Red("Red") + Blue("Blue") + Green("Green") Yellow("Yellow") + Yellow("Yellow") } enum ColorInt(Int) { RedInt(0) BlueInt(1) GreenInt(2) + RedInt(0) + BlueInt(1) + GreenInt(2) YellowInt(3) + YellowInt(3) } enum IotaExpr(Int) { First(1) Second(3) Third(5) + First(1) + Second(3) + Third(5) } enum SimpleIota(Int) { Zero(0) One(1) Two(2) + Zero(0) + One(1) + Two(2) } verb verb(one.Req) one.Resp --- FAIL: TestExtractModuleSchema (0.56s)
Test Go: go-runtime/compile/schema_test.go#L95
=== RUN TestExtractModuleSchemaTwo module two { data Payload<T> { body T } verb two(Payload<String>) Payload<String> verb callsTwo(Payload<String>) Payload<String> +calls two enum TwoEnum(String) { Red("Red") Blue("Blue") Green("Green") Red("Red") Blue("Blue") Green("Green") } } go-runtime/compile/schema_test.go:95: Expected values to be equal: Red("Red") Blue("Blue") Green("Green") +Red("Red") +Blue("Blue") +Green("Green") } verb callsTwo(two.Payload<String>) two.Payload<String> --- FAIL: TestExtractModuleSchemaTwo (0.48s)
Test Go
Process completed with exit code 1.