Skip to content

feat: separate out language logic from moduleconfig #7867

feat: separate out language logic from moduleconfig

feat: separate out language logic from moduleconfig #7867

Triggered via pull request October 7, 2024 05:08
Status Cancelled
Total duration 2m 9s
Artifacts

ci.yml

on: pull_request
Shard Infrastructure Tests
0s
Shard Infrastructure Tests
Shard Integration Tests
4s
Shard Integration Tests
Matrix: Infrastructure Test
Matrix: Integration Test
Integration Success
0s
Integration Success
Fit to window
Zoom out
Zoom in

Annotations

169 errors and 1 warning
Integration Test (TestFollowerSync)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFollowerSync)
The operation was canceled.
Integration Test (TestGoBuildClearsBuildDir)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestGoBuildClearsBuildDir)
The operation was canceled.
Integration Test (TestDeploymentThroughNoopProvisioner)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDeploymentThroughNoopProvisioner)
The operation was canceled.
Lint
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Lint: backend/controller/admin/local_client.go#L59
Error return value of `plugin.Kill` is not checked (errcheck)
Lint: frontend/cli/cmd_schema_diff.go#L109
Error return value of `plugin.Kill` is not checked (errcheck)
Lint: internal/buildengine/languageplugin/java_plugin_test.go#L18
TestJavaConfigDefaults should call t.Parallel on the top level as well as its subtests (tparallel)
Lint: internal/buildengine/languageplugin/go_plugin_test.go#L47
TestGoConfigDefaults should call t.Parallel on the top level as well as its subtests (tparallel)
Lint: internal/moduleconfig/moduleconfig_test.go#L9
TestDefaulting should call t.Parallel on the top level as well as its subtests (tparallel)
Lint: backend/controller/admin/local_client.go#L85
error returned from external package is unwrapped: sig: func (github.com/alecthomas/types/either.Right[*github.com/TBD54566975/ftl/internal/schema.Module, error]).Get() error (wrapcheck)
Lint: go-runtime/compile/build.go#L1191
error returned from external package is unwrapped: sig: func os.WriteFile(name string, data []byte, perm io/fs.FileMode) error (wrapcheck)
Lint: internal/buildengine/languageplugin/go_plugin_helpers.go#L36
error returned from external package is unwrapped: sig: func path/filepath.Rel(basepath string, targpath string) (string, error) (wrapcheck)
Lint: internal/buildengine/languageplugin/go_plugin_helpers.go#L114
error returned from external package is unwrapped: sig: func go/parser.ParseFile(fset *go/token.FileSet, filename string, src any, mode go/parser.Mode) (f *go/ast.File, err error) (wrapcheck)
Lint
The operation was canceled.
Integration Test (TestKMSEncryptorLocalstack)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestKMSEncryptorLocalstack)
The operation was canceled.
Integration Test (TestMigrate)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestMigrate)
The operation was canceled.
Integration Test (TestConfigCmdWithoutController)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConfigCmdWithoutController)
The operation was canceled.
Integration Test (TestRetry)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestRetry)
The operation was canceled.
Integration Test (TestConsoleStreamModules)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConsoleStreamModules)
The operation was canceled.
Integration Test (TestVerbCalls)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestVerbCalls)
The operation was canceled.
Integration Test (TestFSMNext)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFSMNext)
The operation was canceled.
Integration Test (TestInt64BuildError)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestInt64BuildError)
The operation was canceled.
Integration Test (TestHttpEncodeOmitempty)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestHttpEncodeOmitempty)
The operation was canceled.
Integration Test (TestConfigValidation)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConfigValidation)
The operation was canceled.
Integration Test (TestGradle)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestGradle)
The operation was canceled.
Integration Test (TestLifecycleJVM)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLifecycleJVM)
The operation was canceled.
Integration Test (TestFSM)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFSM)
The operation was canceled.
Integration Test (TestLeaseFailure)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLeaseFailure)
The operation was canceled.
Integration Test (TestSecretImportExport)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestSecretImportExport)
The operation was canceled.
Integration Test (TestLeaderSync)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLeaderSync)
The operation was canceled.
Integration Test (TestLocalSchemaDiff)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLocalSchemaDiff)
The operation was canceled.
Integration Test (TestDeploy)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDeploy)
The operation was canceled.
Integration Test (TestJVMCoreFunctionality)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestJVMCoreFunctionality)
The operation was canceled.
Integration Test (TestNonFTLTypes)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestNonFTLTypes)
The operation was canceled.
Integration Test (TestWatchWithBuildModifyingFiles)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestWatchWithBuildModifyingFiles)
The operation was canceled.
Build Runner Docker Image
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Build Runner Docker Image
The operation was canceled.
Rebuild All
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Rebuild All
The operation was canceled.
Integration Test (TestInterModuleCall)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestInterModuleCall)
The operation was canceled.
Integration Test (TestBox)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestBox)
The operation was canceled.
Integration Test (TestFTLMap)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFTLMap)
The operation was canceled.
Build Controller Docker Image
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Build Controller Docker Image
The operation was canceled.
Integration Test (TestUndefinedExportedDecls)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestUndefinedExportedDecls)
The operation was canceled.
Integration Test (TestASMPagination)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestASMPagination)
The operation was canceled.
Integration Test (TestLease)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLease)
The operation was canceled.
Integration Test (TestWatch)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestWatch)
The operation was canceled.
Integration Test (TestNonExportedDecls)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestNonExportedDecls)
The operation was canceled.
Integration Test (TestPubSub)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestPubSub)
The operation was canceled.
Integration Test (TestDiskSchemaRetrieverWithBuildArtefact)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDiskSchemaRetrieverWithBuildArtefact)
The operation was canceled.
Integration Test (TestEncryptionForPubSub)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestEncryptionForPubSub)
The operation was canceled.
Integration Test (TestDefaultToRootWhenModuleDirsMissing)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDefaultToRootWhenModuleDirsMissing)
The operation was canceled.
Integration Test (TestGeneratedTypeRegistry)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestGeneratedTypeRegistry)
The operation was canceled.
Integration Test (TestConsumptionDelay)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConsumptionDelay)
The operation was canceled.
Integration Test (TestSecretsWithoutController)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestSecretsWithoutController)
The operation was canceled.
Integration Test (TestCron)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestCron)
The operation was canceled.
Integration Test (TestASMWorkflow)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestHttpIngressWithCors)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestHttpIngressWithCors)
The operation was canceled.
Integration Test (TestASMWorkflow)
The operation was canceled.
Integration Test (TestRealMap)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestRealMap)
The operation was canceled.
Integration Test (TestResetSubscription)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestResetSubscription)
The operation was canceled.
Integration Test (TestDatabase)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDatabase)
The operation was canceled.
Integration Test (TestEncryptionForLogs)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestEncryptionForLogs)
The operation was canceled.
Integration Test (TestFSMGoTests)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFSMGoTests)
The operation was canceled.
Integration Test (TestEncryptionForFSM)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestEncryptionForFSM)
The operation was canceled.
Console e2e
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Console e2e
The operation was canceled.
Integration Test (TestTypeRegistryUnitTest)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestTypeRegistryUnitTest)
The operation was canceled.
Integration Test (TestSmokeTest)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLifecycle)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestSmokeTest)
The operation was canceled.
Integration Test (TestLifecycle)
The operation was canceled.
Integration Test (TestFSMRetry)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFSMRetry)
The operation was canceled.
Integration Test (TestConfigImportExport)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConfigImportExport)
The operation was canceled.
Integration Test (TestConfigsWithoutController)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConfigsWithoutController)
The operation was canceled.
Integration Test (TestExternalPublishRuntimeCheck)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestExternalPublishRuntimeCheck)
The operation was canceled.
Integration Test (TestDeploymentThrougDevProvisionerCreatePostgresDB)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDeploymentThrougDevProvisionerCreatePostgresDB)
The operation was canceled.
Integration Test (TestFindConfig)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestFindConfig)
The operation was canceled.
Intellij Plugin
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Test README
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Intellij Plugin
The operation was canceled.
Test README
The operation was canceled.
Integration Test (TestNonStructRequestResponse)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestNonStructRequestResponse)
The operation was canceled.
Integration Test (TestLocalScaling)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestLocalScaling)
The operation was canceled.
Integration Test (TestDiskSchemaRetrieverWithNoSchema)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestDiskSchemaRetrieverWithNoSchema)
The operation was canceled.
Integration Test (TestConfigsWithController)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConfigsWithController)
The operation was canceled.
Integration Test (TestConsoleGetModules)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestConsoleGetModules)
The operation was canceled.
Integration Test (TestAdminNoValidationWithNoSchema)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestAdminNoValidationWithNoSchema)
The operation was canceled.
Integration Test (TestExternalType)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestExternalType)
The operation was canceled.
Build Box Docker Image
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Build Box Docker Image
The operation was canceled.
Test Go
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Test Go
The operation was canceled.
Integration Test (TestCycleDetection)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestCycleDetection)
The operation was canceled.
Integration Test (TestRuntimeReflection)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestModuleUnitTests)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestRuntimeReflection)
The operation was canceled.
Integration Test (TestModuleUnitTests)
The operation was canceled.
Integration Test (TestWatchWithBuildAndUserModifyingFiles)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestWatchWithBuildAndUserModifyingFiles)
The operation was canceled.
Integration Test (TestSchemaGenerate)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestSchemaGenerate)
The operation was canceled.
Integration Test (TestSecretsWithController)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestSecretsWithController)
The operation was canceled.
Integration Test (TestHttpIngress)
Canceling since a higher priority waiting request for 'refs/pull/3016/merge-ci' exists
Integration Test (TestHttpIngress)
The operation was canceled.
Lint: internal/moduleconfig/moduleconfig.go#L149
exported: comment on exported method UnvalidatedModuleConfig.FillDefaultsAndValidate should be of the form "FillDefaultsAndValidate ..." (revive)