feat: add external plugin to build engine #7824
Annotations
10 errors and 5 warnings
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin.go#L235
Error return value of `p.client.buildContextUpdated` is not checked (errcheck)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin.go#L210
singleCaseSwitch: should rewrite switch statement to if statement (gocritic)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_client.go#L23
interface method getCreateModuleFlags must have named param for type context.Context (inamedparam)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_client.go#L24
interface method createModule must have named param for type context.Context (inamedparam)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_client.go#L25
interface method getDependencies must have named param for type context.Context (inamedparam)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_client.go#L28
interface method build must have named param for type context.Context (inamedparam)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_client.go#L29
interface method buildContextUpdated must have named param for type context.Context (inamedparam)
|
|
golangci-lint:
internal/buildengine/languageplugin/plugin.go#L35
ST1021: comment on exported type CompilerBuildError should be of the form "CompilerBuildError ..." (with optional leading article) (stylecheck)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_test.go#L106
TestCreateModuleFlags should call t.Parallel on the top level as well as its subtests (tparallel)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin.go#L81
error returned from interface method should be wrapped: sig: func (github.com/TBD54566975/ftl/internal/buildengine/languageplugin.externalPluginClient).kill() error (wrapcheck)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_test.go#L22
var-naming: struct field buildRequestId should be buildRequestID (revive)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_test.go#L215
var-naming: var realId should be realID (revive)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin_test.go#L316
var-naming: func parameter buildRequestId should be buildRequestID (revive)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin.go#L279
var-naming: var requestId should be requestID (revive)
|
|
golangci-lint:
internal/buildengine/languageplugin/external_plugin.go#L338
var-naming: func buildRequestId should be buildRequestID (revive)
|
Loading