feat: change how runner provisioning works #6757
Annotations
6 errors and 2 warnings
backend/controller/scaling/scaling.go#L26
Error return value of `lease.Release` is not checked (errcheck)
|
internal/rpc/rpc.go#L247
SA5001: should check error returned from rpc() before deferring stream.Close() (staticcheck)
|
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L200
error returned from external package is unwrapped: sig: func k8s.io/apimachinery/pkg/runtime.DecodeInto(d k8s.io/apimachinery/pkg/runtime.Decoder, data []byte, into k8s.io/apimachinery/pkg/runtime.Object) error (wrapcheck)
|
backend/runner/runner.go#L263
error returned from interface method should be wrapped: sig: func (github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1/ftlv1connect.ControllerServiceClient).GetDeployment(context.Context, *connectrpc.com/connect.Request[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetDeploymentRequest]) (*connectrpc.com/connect.Response[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetDeploymentResponse], error) (wrapcheck)
|
backend/controller/scaling/localscaling/local_scaling.go#L133
error returned from external package is unwrapped: sig: func github.com/alecthomas/kong.ApplyDefaults(target interface{}, options ...github.com/alecthomas/kong.Option) error (wrapcheck)
|
|
|
backend/controller/scaling/scaling.go#L38
context-as-argument: context.Context should be the first parameter of a function (revive)
|
This job failed
Loading