feat: change how runner provisioning works #6754
alecthomasci.yml
on: pull_request
Shard Integration Tests
0s
Test Go
3m 28s
Test README
1m 13s
Test Scripts
10s
SQL
57s
Ensure Frozen Migrations
7s
Lint
2m 11s
Proto Breaking Change Check
7s
Console
42s
VSCode Extension
56s
Intellij Plugin
0s
Rebuild All
0s
Build Docs
5s
Lint Architecture
15s
Build Controller Docker Image
0s
Build Runner Docker Image
0s
Build Box Docker Image
0s
Console e2e
0s
Matrix: Integration Test
Integration Success
0s
Annotations
28 errors and 7 warnings
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present message "DeployRequest" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present message "DeployResponse" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present message "ReserveRequest" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present message "ReserveResponse" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present message "TerminateRequest" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L1
Previously present service "RunnerService" was deleted from file.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L210
Previously present enum value "3" on enum "RunnerState" was deleted.
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L212
Enum value "0" on enum "RunnerState" changed name from "RUNNER_IDLE" to "RUNNER_NEW".
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L214
Enum value "1" on enum "RunnerState" changed name from "RUNNER_RESERVED" to "RUNNER_ASSIGNED".
|
|
Proto Breaking Change Check:
backend/protos/xyz/block/ftl/v1/ftl.proto#L216
Enum value "2" on enum "RunnerState" changed name from "RUNNER_ASSIGNED" to "RUNNER_DEAD".
|
|
Console
Process completed with exit code 2.
|
|
Test README
Process completed with exit code 1.
|
|
Lint:
backend/controller/scaling/scaling.go#L26
Error return value of `lease.Release` is not checked (errcheck)
|
|
Lint:
backend/controller/scaling/k8sscaling/k8s_scaling.go#L44
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
Lint:
backend/controller/scaling/k8sscaling/k8s_scaling.go#L62
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
Lint:
backend/controller/scaling/k8sscaling/k8s_scaling.go#L71
non-wrapping format verb for fmt.Errorf. Use `%w` to format errors (errorlint)
|
|
Lint:
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L219
ineffectual assignment to err (ineffassign)
|
|
Lint:
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L235
ineffectual assignment to err (ineffassign)
|
|
Lint:
internal/rpc/rpc.go#L247
SA5001: should check error returned from rpc() before deferring stream.Close() (staticcheck)
|
|
Lint:
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L61
error returned from interface method should be wrapped: sig: func (k8s.io/client-go/kubernetes/typed/apps/v1.DeploymentInterface).Get(ctx context.Context, name string, opts k8s.io/apimachinery/pkg/apis/meta/v1.GetOptions) (*k8s.io/api/apps/v1.Deployment, error) (wrapcheck)
|
|
Lint:
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L70
error returned from interface method should be wrapped: sig: func (k8s.io/client-go/kubernetes/typed/apps/v1.DeploymentInterface).Update(ctx context.Context, deployment *k8s.io/api/apps/v1.Deployment, opts k8s.io/apimachinery/pkg/apis/meta/v1.UpdateOptions) (*k8s.io/api/apps/v1.Deployment, error) (wrapcheck)
|
|
Lint:
backend/controller/scaling/k8sscaling/deployment_provisioner.go#L95
error returned from interface method should be wrapped: sig: func (k8s.io/client-go/kubernetes/typed/apps/v1.DeploymentInterface).Get(ctx context.Context, name string, opts k8s.io/apimachinery/pkg/apis/meta/v1.GetOptions) (*k8s.io/api/apps/v1.Deployment, error) (wrapcheck)
|
|
Test Go:
backend/controller/dal/dal_test.go#L113
=== RUN TestDAL/RegisterRunner
backend/controller/dal/dal_test.go:113: Did not expect an error but got:
null value in column "deployment_id" of relation "runners" violates not-null constraint: constraint violation
--- FAIL: TestDAL/RegisterRunner (0.00s)
|
|
Test Go:
backend/controller/dal/dal_test.go#L124
=== RUN TestDAL/RegisterRunnerFailsOnDuplicate
backend/controller/dal/dal_test.go:124: Error tree null value in column "deployment_id" of relation "runners" violates not-null constraint: constraint violation should contain error "conflict"
--- FAIL: TestDAL/RegisterRunnerFailsOnDuplicate (0.00s)
|
|
Test Go:
backend/controller/dal/dal_test.go#L282
=== RUN TestDAL/UpdateRunnerInvalidDeployment
backend/controller/dal/dal_test.go:282: Error tree null value in column "deployment_id" of relation "runners" violates not-null constraint: constraint violation should contain error "not found"
--- FAIL: TestDAL/UpdateRunnerInvalidDeployment (0.00s)
|
|
Test Go:
backend/controller/dal/dal_test.go#L287
=== RUN TestDAL/GetRoutingTable#01
backend/controller/dal/dal_test.go:287: Error tree <nil> should contain error "not found"
--- FAIL: TestDAL/GetRoutingTable#01 (0.00s)
|
|
Test Go:
backend/controller/dal/dal_test.go#L292
=== RUN TestDAL/DeregisterRunner
backend/controller/dal/dal_test.go:292: Did not expect an error but got:
null value in column "deployment_id" of relation "runners" violates not-null constraint: constraint violation
--- FAIL: TestDAL/DeregisterRunner (0.00s)
|
|
Test Go
Process completed with exit code 1.
|
|
Console
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
VSCode Extension
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
SQL
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
Test README
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
Lint
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|
|
Lint:
backend/controller/scaling/scaling.go#L38
context-as-argument: context.Context should be the first parameter of a function (revive)
|
|
Test Go
Failed to restore: "/usr/bin/tar" failed with error: The process '/usr/bin/tar' failed with exit code 2
|