fix: possible race on artefact upload #6098
alecthomasci.yml
on: pull_request
Shard Integration Tests
0s
Test Go
2m 22s
Test README
1m 46s
Test Scripts
5s
SQL
52s
Ensure Frozen Migrations
11s
Lint
1m 21s
Proto Breaking Change Check
6s
Console
1m 3s
VSCode Extension
40s
Rebuild All
0s
Build Docs
9s
Matrix: Integration Test
Integration Success
2s
Annotations
3 errors and 1 warning
|
Lint:
buildengine/deploy.go#L82
error returned from interface method should be wrapped: sig: func (github.com/TBD54566975/ftl/buildengine.DeployClient).GetArtefactDiffs(ctx context.Context, req *connectrpc.com/connect.Request[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetArtefactDiffsRequest]) (*connectrpc.com/connect.Response[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetArtefactDiffsResponse], error) (wrapcheck)
|
|
Lint:
buildengine/deploy.go#L86
error returned from interface method should be wrapped: sig: func (github.com/TBD54566975/ftl/buildengine.DeployClient).GetArtefactDiffs(ctx context.Context, req *connectrpc.com/connect.Request[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetArtefactDiffsRequest]) (*connectrpc.com/connect.Response[github.com/TBD54566975/ftl/backend/protos/xyz/block/ftl/v1.GetArtefactDiffsResponse], error) (wrapcheck)
|
|
Lint
Process completed with exit code 1.
|
|
Lint:
buildengine/deploy.go#L87
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
|