Improve shard routing and search index expression test coverage. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myronmarston
force-pushed
the
myron/use-filter-node-interpreter/step4
branch
from
53acfad to
53b78a6
Compare
myronmarston
changed the title
time_of_day filtering in search_index_expression_spec.rb.
myronmarston
force-pushed
the
myron/use-filter-node-interpreter/step3
branch
from
a822b1d to
490a575
Compare
I'm working on a refactoring to `FilterValueSetExtractor` and discovered that these cases weren't covered by a test. Our 100% test coverage would drop if I didn't introduce these test cases.
myronmarston
force-pushed
the
myron/use-filter-node-interpreter/step4
branch
from
53b78a6 to
244dad6
Compare
acerbusace
approved these changes
Dec 10, 2024
Base automatically changed from
myron/use-filter-node-interpreter/step3
to
main
December 10, 2024 15:10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a refactoring to
FilterValueSetExtractorand discovered that these cases weren't covered by a test. Our 100% test coverage would drop if I didn't introduce these test cases.