Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore GraphQL::Schema#defined_types. #33

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

myronmarston
Copy link
Collaborator

I removed it in #31 because ElasticGraph didn't rely on it or need it. However, I discovered that Block has an internal extension library that relies on it, and it's a generally useful API to offer for extension libraries. This restores it (but with a simplified implementation).

I removed it in #31 because ElasticGraph didn't rely on it or need it.
However, I discovered that Block has an internal extension library that
relies on it, and it's a generally useful API to offer for extension
libraries. This restores it (but with a simplified implementation).
Copy link
Collaborator

@BrianSigafoos-SQ BrianSigafoos-SQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@myronmarston myronmarston merged commit 1f939ed into main Nov 12, 2024
10 checks passed
@myronmarston myronmarston deleted the myron/defined-types branch November 12, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants