Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add panel header icon #906

Merged
merged 5 commits into from
Apr 2, 2024

Conversation

agaertner
Copy link
Member

@agaertner agaertner commented Aug 20, 2023

Adding a minor optional title icon to panel as it has been often suggested in the Discord.
I've actually done this through reflection in Proof Logix because I didn't want to copy the entire class.
https://github.com/agaertner/bhm-proof-logix/blob/main/src/Core/UI/FlowPanelWithIcon.cs

Usage example:
image

Example:

Is this a breaking change?

No

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dlamkins
Copy link
Member

I'm willing to accept this as a feature. Could you take a look at the spacing used in the Characters module, though? It seems a bit tighter there and I think I prefer it.

image

@agaertner
Copy link
Member Author

agaertner commented Jan 1, 2024

I'm willing to accept this as a feature. Could you take a look at the spacing used in the Characters module, though? It seems a bit tighter there and I think I prefer it.

image

It looks 2 pixel closer to the left edge. I will move it.

EDIT: I adjusted it to match the padding in your example (source).

Copy link

sonarcloud bot commented Jan 1, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
6.3% Duplication on New Code (required ≤ 6%)

See analysis details on SonarCloud

@dlamkins dlamkins merged commit 3fb24bd into blish-hud:dev Apr 2, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants