-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
48 button #1
48 button #1
Conversation
No, I don't want to use the default Raised Button. It is not like the one which is in the design. Even if similar, default raised button won't match the other styles which will be used throughout the app. 😞 |
Then you shouldn't use the Material UI button. Rather, create your own
component.
…On Fri, May 11, 2018, 10:17 PM Akash Hamirwasia ***@***.***> wrote:
No, I don't want to use the default Raised Button. It is not like the one
which is in the design. Even if similar, default raised button won't match
the other styles which will be used throughout the app. 😞
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABhiQW4y2ehUcvuKlDoTMDmwEwmoLIDnks5txcCZgaJpZM4T6iOM>
.
|
But I want the ripple and raised effect also of the default button, hence overriding that component. Creating a custom button component with those features would make it more complicated |
Raised button is exactly that!
…On Fri, May 11, 2018, 10:55 PM Akash Hamirwasia ***@***.***> wrote:
But I want the ripple and raised effect also of the default button, hence
overriding that component.
Creating a custom button component with those features would make it more
complicated
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABhiQUSRLmcEWHJfrNxlnJ5OflApdcD6ks5txclxgaJpZM4T6iOM>
.
|
I think we can style the existing button and use that button component throughout the app, @blenderskool has completed that part, it will be great with the design. The characteristics of the elements can be changed via css so it won't be an issue. |
But some styles are not the same. Font weights, sizes, padding, shadows, many things are different |
@divyamrastogi @anurag-majumdar Lets finish the basic working of the app. I don't think we should use the default raised button. If we use it, then we can use all the default components itself... which is very repetitive as of now until the new material design comes for web. |
Closing this request since we should focus on finishing the development of the app. |
Fixes UdacityMobileWebScholarship#48
I've removed the CSS file, it wasn't necessary. You can directly use the raised button for our purpose, we don't have to overwrite any of the component-specific styles, we can use them as is.
More documentation about components: https://www.material-ui.com/#/components/raised-button
Checklist
master
branch.Merge this request and then we'll merge your branch with the master.