Fix for FileNotFoundError when there is no GOES data. #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added option to ignore missing directories due to satellite outages.
Added option to ignore FileNotFoundError due to satellite outages.
Added support in config to ignore_missing for satellite outages.
Added further support for ignore_missing.
ignore_missing = true for timerange
Minor readability improvement.
|
Thanks for the PR. Looks great. I like that you added the option to the default config file, too. I'll merge this now, but do you have a specific date that was problematic? It would be nice to eventually add a test for this case. |
|
Hi, thanks for merging. One example would be the 6th January 2020, which is also mentioned in #86. For the summer months JJA 2020 to 2022 the days with missing data are:
The latter two dates are specially interesting, because only a part of the channels are missing, mostly during 17-18 UTC. This leads to missing data in the L2 products. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I've coded an option to ignore
FileNotFoundErrorerrors raised by theS3FileSystem.ls()function. The error occurs because the goes2go library assumes to find a folder for each hour of the day, but due to satellite outages or similar events, some folders are missing.This fixes issue #93 and addresses the discussion #86
This issue has bothered me several times and I hope my fix is up to standard. If not, I'd love it if you implement something similar.