Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database adapter pkg #30

Open
wants to merge 46 commits into
base: master
Choose a base branch
from
Open

Conversation

kanataxa
Copy link
Contributor

@kanataxa kanataxa commented Mar 2, 2020

Refs: #29

Add database_adapter package for supporting other databases.

@codecov-io
Copy link

codecov-io commented Mar 2, 2020

Codecov Report

Merging #30 into master will decrease coverage by 0.00%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   71.55%   71.54%   -0.01%     
==========================================
  Files          21       21              
  Lines        8772     8776       +4     
==========================================
+ Hits         6277     6279       +2     
- Misses       1770     1771       +1     
- Partials      725      726       +1     
Impacted Files Coverage Δ
rapidash.go 70.97% <60.00%> (-0.21%) ⬇️
first_level_cache.go 78.92% <66.66%> (-0.19%) ⬇️
second_level_cache.go 69.30% <84.61%> (-0.10%) ⬇️
query_builder.go 81.33% <95.34%> (+0.07%) ⬆️
option.go 97.50% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1eb9f...d703d86. Read the comment docs.

@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020

Codecov Report

Merging #30 into master will decrease coverage by 0.03%.
The diff coverage is 78.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   71.55%   71.52%   -0.04%     
==========================================
  Files          21       21              
  Lines        8772     8786      +14     
==========================================
+ Hits         6277     6284       +7     
- Misses       1770     1776       +6     
- Partials      725      726       +1     
Impacted Files Coverage Δ
rapidash.go 70.97% <60.00%> (-0.21%) ⬇️
second_level_cache.go 69.15% <60.00%> (-0.25%) ⬇️
first_level_cache.go 78.92% <66.66%> (-0.19%) ⬇️
query_builder.go 81.19% <92.06%> (-0.07%) ⬇️
option.go 97.50% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc1eb9f...a59e6c6. Read the comment docs.

@kanataxa kanataxa changed the title [WIP]Add database adapter pkg Add database adapter pkg Jun 14, 2020
@yosuke310
Copy link

Will you do not support for benchmarking with postgres?
It looks like it can be handled by doing the following.

・Use driver values
・Branch CREATE TABLE syntax
・Branch placeholders syntax

@@ -52,119 +81,75 @@ func initDB() error {
return nil
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, initDB() in tx_test.go seems to be not supported posgresql.
(I can't execute these tests.)
So I want you to be able to select the driver here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants