Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): obfuscate token while logging in debug mode #436

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ngouy
Copy link
Contributor

@ngouy ngouy commented Dec 19, 2024

Pull Request Description

Obfuscate the token in the transporter class used to log things in debug mode

Related Issue(s)

  • This is a new feature and does not have an associated issue.

Additional Information

  • This change is a breaking change if you are expecting to see plain tokens in logs

Test Cases

No test included. Build and use it in my code, this is my result:

image


Documentation

  • No updates are required.

Checklist

  • I have read the CONTRIBUTING documentation.
  • My code follows the coding standards of this project.
  • All new and existing tests passed.

@ngouy ngouy marked this pull request as ready for review December 19, 2024 21:32
@blakmatrix
Copy link
Owner

Hi @ngouy

Thanks for the PR! The code change looks solid, and the obfuscation improves security in debug logs. I'm good with merging this as-is.

Appreciate your contribution!

Best,
Farrin

@blakmatrix blakmatrix merged commit 5230cde into blakmatrix:master Dec 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants